Wrong file doctype, path information, and copyright date in files created by plugin

[mtub]

When the translator plugin creates new files, some of the XML file header lines differ from the en_US original file (at least with plugin translations):

• DTD path is wrong
• path information in comment is generic, not copied from the en_US original
• copyright date is "-2016" (en_US: -2017)

This results in us getting translations that need unnecessary cleanup, because at least the dtd error has to be removed.

To verify:

• create new, formerly untranslated file (e.g. a plugin translation) with the translator plugin
• head locale/en_US/locale.xml
• head locale/xx_XX/locale.xml

Example

en_US

<?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE locale SYSTEM "../../../../../lib/pkp/dtd/locale.dtd"> ` <!-- plugins/generic/googleScholar/locale/en_US/locale.xml Copyright (c) 2014-2017 Simon Fraser University Copyright (c) 2003-2017 John Willinsky`

newly created de_DE file

<?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE locale SYSTEM "../../../../lib/pkp/dtd/locale.dtd"> ` <!-- locale/de_DE/locale.xml Copyright (c) 2014-2016 Simon Fraser University Library Copyright (c) 2003-2016 John Willinsky`

[asmecher]

The blank comes from registry/locale.xml in the plugin repo, just FYI. More of the header stuff could stand to be made into variables rather than taken directly from the blank.

[zuphilip]

See also https://github.com/ajnyga/disqus/pull/4 for an example of such cleanup, which would make more sense to do it correctly in the translator plugin in the first place.

[mtub]

Since this results in many extra hours of work to track the errors introduced by the plugin, I would really welcome a fix for this, @asmecher.