Fix for: Only variables should be passed by reference

pkp / translator

PKP Translator plugin for OMP 1.1.1+ and OJS 3.0+

GNU General Public License v2.0

6 stars 30 forks source link

Fix for: Only variables should be passed by reference #52

Closed danmichaelo closed 5 years ago

danmichaelo commented 5 years ago

Hi. We got the following notice on PHP 7.1.29 and OJS 3.1.2.0:

PHP Notice:  Only variables should be passed by reference in /www/var/data/ojs/htdocs/plugins/generic/translator/TranslatorPlugin.inc.php on line 73

Which in turn caused the Translator tab to not show up. This seems to fix it.

asmecher commented 5 years ago

Merged and cherry-picked to stable-3_1_2, thanks. (Newer releases of PHP are pickier about this.) Note that we're working on replacing our bespoke toolset with an XLIFF-backed translation store that'll facilitate the use of commodity tools like Weblate, POEdit, etc: https://github.com/pkp/pkp-lib/issues/4779

danmichaelo commented 5 years ago

Thanks @asmecher, amazing work on #4779!

asmecher commented 5 years ago

Thanks, @danmichaelo!