Fix LocaleGridRow::initialize() declaration

pkp / translator

PKP Translator plugin for OMP 1.1.1+ and OJS 3.0+

GNU General Public License v2.0

6 stars 30 forks source link

Fix LocaleGridRow::initialize() declaration #53

Closed danmichaelo closed 5 years ago

danmichaelo commented 5 years ago

Another one. We got the following warning:

PHP Warning:  Declaration of LocaleGridRow::initialize($request) should be compatible with GridRow::initialize($request, $template = NULL) in /.../plugins/generic/translator/controllers/grid/LocaleGridRow.inc.php on line 74

I'm not sure if this is a proper fix, but it makes the plugin work for us again. On PHP 7.1.29 and OJS 3.1.2.0

asmecher commented 5 years ago

Thanks, @danmichaelo -- that'll work, but I've suggested a tweak that's slightly "cleaner".

danmichaelo commented 5 years ago

Ah, yeah, of course 👍 I amended my commit now :)

asmecher commented 5 years ago

Thanks for contributing, @danmichaelo! Merged and cherry-picked to stable-3_1_2.