pkpaing / pe

0 stars 0 forks source link

Displayed modules for sort feature #4

Open pkpaing opened 1 year ago

pkpaing commented 1 year ago

Screenshot 2023-04-14 at 2.35.38 PM.png How to replicate: find cs2101 lecture -> sort deadline -> sort timeslot

The sort command only appears to sort the currently shown modules (e.g. after a find command) instead of all my modules. The usage of the words "the modules" (see screenshot line 2) makes it unclear whether the sort command is supposed to sort all the modules or whether it stacks with the find command. As a user, if I want to see all my sorted modules after a find and i forget to type in list first, it will cause a minor inconvenience to me.

soc-pe-bot commented 1 year ago

Team's Response

Thanks for the feedback. Will consider for future enhancement

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: As a user, if want to sort all my modules after a find command, I would intuitively just key in the 'sort TIMELINE/DEADLINE' command instead of refreshing the displayed modules with a 'list' command first. From the explanation in the user guide, this is the functionality I would infer from the phrase ''you can display the modules in sorted order".

However, the incorrect sort result (due to it sorting only the currently displayed list), would leave me confused as to why the list is shorter than my full list of modules. I may even think that I the application had accidentally erased some of my modules, and start adding back the modules using the 'add' command. In this manner, this would cause me a minor inconvenience in the rare instances where I use the find and sort commands consecutively. Thus, I feel like this should be a severity.Low and not NotInScope.


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]