search

pkpdapp-team / pkpdapp

A web application for modeling the distribution and effects of drugs.
BSD 3-Clause "New" or "Revised" License
9 stars 3 forks source link

build(frontend): refactor Plotly imports #483

Closed eatyourgreens closed 2 months ago

eatyourgreens commented 2 months ago

Import Plotly from plotly.js-basic-dist-min but load types from @types/plotly.js.

eatyourgreens commented 2 months ago

yarn build fails on this branch. 😞

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.87%. Comparing base (28944d1) to head (8702dab). Report is 36 commits behind head on development.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #483 +/- ## =============================================== - Coverage 76.88% 76.87% -0.01% =============================================== Files 108 108 Lines 5593 5609 +16 =============================================== + Hits 4300 4312 +12 - Misses 1293 1297 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed for 'pkpdapp'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed for 'pkpdapp-team_pkpdapp_frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

eatyourgreens commented 2 months ago

Fixed the build, but there should probably be a CI step that runs the Vite build.