pkpdapp-team / pkpdapp

A web application for modeling the distribution and effects of drugs.
BSD 3-Clause "New" or "Revised" License
9 stars 3 forks source link

refactor(frontend): validate dosing units in uploaded CSVs #500

Closed eatyourgreens closed 1 month ago

eatyourgreens commented 1 month ago

CSVs can be uploaded with dosing units that aren't listed in the app. This PR validates the 'Amount Unit' column and ignores it if it contains any invalid values. When amount untis are invalid, the user must manually enter dosing units.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed for 'pkpdapp'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed for 'pkpdapp-team_pkpdapp_frontend'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.26%. Comparing base (ad4e0bc) to head (49e9e2c). Report is 2 commits behind head on development.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #500 +/- ## =============================================== + Coverage 76.22% 76.26% +0.04% =============================================== Files 108 108 Lines 5594 5591 -3 =============================================== Hits 4264 4264 + Misses 1330 1327 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.