pkpfrench / dropdown-check-list

Automatically exported from code.google.com/p/dropdown-check-list
0 stars 0 forks source link

The plugin not work in jquery 1.6 #180

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
** What steps will reproduce the problem?
It doesn't by default add the value of the options with selected attribute to 
the box

** What is the expected output? What do you see instead?
A list of value added in the input/combo box where you normally see

** What is your environment?
-- DropDownCheckList version: 1.3
-- jQuery version: 1.6
-- jQuery UI version: 1.8
-- Browser and version: Chrome 8+

** Please provide any additional information below/Please attach sample
html
Mostly due to incompability with jquery 1.6

Original issue reported on code.google.com by flyingangel1987 on 9 May 2011 at 12:31

GoogleCodeExporter commented 9 years ago
Same problem with Firefox 4.
Apparently jQuery 1.6 broke quite a few plugins. 
Cannot roll back to 1.5, since 1.6 fixes another plugin for me :(

Original comment by mikhail....@gmail.com on 11 May 2011 at 12:58

GoogleCodeExporter commented 9 years ago
Yeah, please improve the compatibility

Original comment by flyingangel1987 on 11 May 2011 at 6:46

GoogleCodeExporter commented 9 years ago
jQuery 1.6 compatibility will have to wait for DDCL 1.4

If anyone out there in the user community can assist with tracking down the 
jQ1.6 issues, I will try to roll any fixes into a 1.4 release ASAP.

Original comment by womohun...@ittrium.com on 16 May 2011 at 2:44

GoogleCodeExporter commented 9 years ago
to run the plugin again change all of the 
.attr("checked") to .prop("checked")
.attr("checked", "checked") to .prop("checked", true)
.attr("checked", "") to .prop("checked", false)
.removeAttr("checked", "") to .prop("checked", false)

.attr("disabled") to .prop("disabled")
.attr("disabled", "disabled") to .prop("disabled", true)
.attr("disabled", "") to .prop("disabled", false)
.removeAttr("disabled") to .prop("disabled", false)

.attr("selected") to .prop("selected")

this works for me as of jquery 1.6

didn't test very well. so be careful, maybe there are more .attr() which have 
to be changed to .prop

regards 
Mark

Original comment by dersiedl...@gmail.com on 16 May 2011 at 8:50

GoogleCodeExporter commented 9 years ago
Issue 183 has been merged into this issue.

Original comment by womohun...@ittrium.com on 17 May 2011 at 6:31

GoogleCodeExporter commented 9 years ago
to run this plugin with jQuery 1.6.1 simply replace following

Line 499:
allCheckboxes.each(function(index) {
    $(selectOptions[index]).attr("selected", $(this).attr("checked"));
});

with:

allCheckboxes.each(function(index) {
    $(selectOptions[index]).attr("selected", $(this).prop("checked"));
});

Original comment by stepin.a...@gmail.com on 8 Jun 2011 at 6:28

GoogleCodeExporter commented 9 years ago
Issue 187 has been merged into this issue.

Original comment by womohun...@ittrium.com on 13 Jun 2011 at 3:36

GoogleCodeExporter commented 9 years ago
Fixes applied with version 1.4 
Many thanks to all the contributors....

Original comment by womohun...@ittrium.com on 14 Jun 2011 at 9:18