pkrumins / node-lazy

lazy lists for node.js
http://www.catonmat.net
488 stars 52 forks source link

JSHint warnings #38

Open mcandre opened 11 years ago

mcandre commented 11 years ago

I ran JSHint over the code to look for potential sources of bugs. There were a few warnings output:

$ jshint .
lazy.js: line 16, col 6, Missing semicolon.
lazy.js: line 25, col 55, Missing semicolon.
lazy.js: line 33, col 6, Missing semicolon.
lazy.js: line 37, col 6, Missing semicolon.
lazy.js: line 87, col 6, Missing semicolon.
lazy.js: line 94, col 6, Missing semicolon.
lazy.js: line 98, col 38, Missing semicolon.
lazy.js: line 99, col 39, Missing semicolon.
lazy.js: line 101, col 6, Missing semicolon.
lazy.js: line 106, col 17, Missing semicolon.
lazy.js: line 107, col 45, Missing semicolon.
lazy.js: line 108, col 11, Missing semicolon.
lazy.js: line 109, col 6, Missing semicolon.
lazy.js: line 120, col 6, Missing semicolon.
lazy.js: line 130, col 6, Missing semicolon.
lazy.js: line 134, col 19, Use '===' to compare with '0'.
lazy.js: line 137, col 6, Missing semicolon.
lazy.js: line 147, col 6, Missing semicolon.
lazy.js: line 158, col 6, Missing semicolon.
lazy.js: line 161, col 61, Missing semicolon.
lazy.js: line 162, col 6, Missing semicolon.
lazy.js: line 165, col 59, Missing semicolon.
lazy.js: line 166, col 6, Missing semicolon.
lazy.js: line 169, col 22, Missing semicolon.
lazy.js: line 174, col 50, Missing semicolon.
lazy.js: line 176, col 6, Missing semicolon.
lazy.js: line 203, col 6, Missing semicolon.
lazy.js: line 211, col 12, Mixed spaces and tabs.
lazy.js: line 212, col 16, Mixed spaces and tabs.
lazy.js: line 213, col 20, Mixed spaces and tabs.
lazy.js: line 214, col 20, Mixed spaces and tabs.

...

test\skip.js: line 11, col 8, ['skip'] is better written in dot notation.
test\skip.js: line 12, col 20, Missing '()' invoking a constructor.
test\skip.js: line 26, col 2, Missing semicolon.

test\sum.js: line 11, col 8, ['sum'] is better written in dot notation.
test\sum.js: line 12, col 20, Missing '()' invoking a constructor.
test\sum.js: line 17, col 7, Missing semicolon.
test\sum.js: line 25, col 2, Missing semicolon.

test\tail.js: line 11, col 8, ['tail'] is better written in dot notation.
test\tail.js: line 12, col 20, Missing '()' invoking a constructor.
test\tail.js: line 26, col 2, Missing semicolon.

test\take.js: line 11, col 8, ['take'] is better written in dot notation.
test\take.js: line 12, col 20, Missing '()' invoking a constructor.
test\take.js: line 25, col 2, Missing semicolon.

test\takeWhile.js: line 11, col 8, ['takeWhile'] is better written in dot notation.
test\takeWhile.js: line 12, col 20, Missing '()' invoking a constructor.
test\takeWhile.js: line 15, col 47, Missing semicolon.
test\takeWhile.js: line 25, col 2, Missing semicolon.

133 errors

I'm not familiar enough with the codebase to change these myself, just through I'd mention.

pkrumins commented 11 years ago

Thanks but I don't consider any of these issues serious.

mcandre commented 11 years ago

I respect that. Would you mind if I refactored a little bit to get these to go away?