search

pkrumins / node-tree-kill

kill trees of processes
MIT License
333 stars 37 forks source link

Callback support #3

Closed yeputons closed 9 years ago

yeputons commented 10 years ago

Right now you have no information about when actually all processes were killed: if taskkill/ps took time, there is no chance for user to know about it. Function is neither sync, nor calls callback.

yeputons commented 10 years ago

Please note that if callback support is added, it will be a good plan to add error handling as well (for example, if ps or taskkill fails with non-zero exit code)

billiegoose commented 9 years ago

Closing this because the original issue (callback support) has been added.

Error handling should be a separate issue. I'm not exactly sure how to handle that right now.