prefer /usr/bin/pgrep to other pgrep if available

pkrumins / node-tree-kill

kill trees of processes

MIT License

333 stars 37 forks source link

prefer /usr/bin/pgrep to other pgrep if available #33

Open hyangah opened 4 years ago

hyangah commented 4 years ago

Use the default pgrep, available since os x mountain lion. proctools' pgrep does not implement -P correctly, returns unrelated processes, breaks tree-kill's assumption, and may cause a large number of pgrep processes.

Reported in https://github.com/pkrumins/node-tree-kill/issues/17#issuecomment-484206992

Update https://github.com/golang/vscode-go/issues/90#issuecomment-634430428

hyangah commented 4 years ago

Is there any chance this gets reviewed? Thanks!

hyangah commented 3 years ago

@TomasFlow Thanks for the approval. What's the next step? Will the new version be released?