pkrumins / node-tree-kill

kill trees of processes
MIT License
333 stars 37 forks source link

Parse pid because it's string (object's key). #4

Closed villelahdenvuo closed 9 years ago

villelahdenvuo commented 9 years ago

Getting error that pid must be a number in unstable Node.js.

billiegoose commented 9 years ago

I'm thinking the coercion should happen when calling process.kill() rather than when calling killPid()... Note to self: fix this tomorrow.

billiegoose commented 9 years ago

Alright, fixed this in commit 539797095d0c73099d46cceae56cab367b8fa702, and published as v0.1.1

villelahdenvuo commented 9 years ago

Great! :+1: