search

pksprojects / ElasticSwift

Elasticsearch client in swift
MIT License
46 stars 18 forks source link

Refactor + fixes on Dev #23

Closed lubbo closed 5 years ago

lubbo commented 5 years ago

I rebased on dev branch ... it was a pain :) I kindly ask you to review the PR and take actions before merging other changes otherwise it may be difficult for me to rebase again.

Thanks!

lubbo commented 5 years ago

The only test that fails is testGetIndexAdmin

Travis-Ci is setup with ES 6.8 and the get index JSON result is different from expected. The root object contains the name of the index and inside that the index result.

This is the error log:

Get Index Handler: nil Error: Optional(ElasticSwift.RequestConstants.Errors.Response.Deserialization(content: "Error decoding response with data: {\"test\":{\"aliases\":{},\"mappings\":{},\"settings\":{\"index\":{\"creation_date\":\"1561020320408\",\"number_of_shards\":\"5\",\"number_of_replicas\":\"1\",\"uuid\":\"mzwnPUALS7Gitqk8jXQfTQ\",\"version\":{\"created\":\"6080099\"},\"provided_name\":\"test\"}}}} Underlying error: The data couldn’t be read because it isn’t in the correct format.")) /Users/travis/build/pksprojects/ElasticSwift/Tests/ElasticSwiftTests/ElasticSwiftTests.swift:87: error: -[ElasticSwiftTests.ElasticSwiftTests testGetIndexAdmin] : XCTAssertNil failed: "Deserialization(content: "Error decoding response with data: {\"test\":{\"aliases\":{},\"mappings\":{},\"settings\":{\"index\":{\"creation_date\":\"1561020320408\",\"number_of_shards\":\"5\",\"number_of_replicas\":\"1\",\"uuid\":\"mzwnPUALS7Gitqk8jXQfTQ\",\"version\":{\"created\":\"6080099\"},\"provided_name\":\"test\"}}}} Underlying error: The data couldn’t be read because it isn’t in the correct format.")"

prafsoni commented 5 years ago

@lubbo I have major changes throughout the lib in order to modularize it. I will merge it to dev and pull the fixes/changes. Will include them in next release.