search

pksprojects / ElasticSwift

Elasticsearch client in swift
MIT License
46 stars 18 forks source link

Unit Tests - Missing asserts on real tests results #8

Closed lubbo closed 5 years ago

lubbo commented 5 years ago

In the unit tests, the tests results are not asserted. My elastic instance is not running on localhost, so each API invocation fails but tests are reported as ended successfully.

prafsoni commented 5 years ago

Since Project is still in alpha unit tests are not very reliable. As ElasticSwift moves to beta, more unit tests and assertions will start popping up. With that said, Any contributions to the project are welcome.

prafsoni commented 5 years ago

19