Don't commit tags / git commit if publishing fails

pksunkara / cargo-workspaces

A tool for managing cargo workspaces and their crates, inspired by lerna

MIT License

483 stars 46 forks source link

Don't commit tags / git commit if publishing fails #162

Closed jkelleyrtp closed 3 months ago

jkelleyrtp commented 3 months ago

I frequently run into issues with this (fantastic!) command due to some edge cases in our large repo and then my repo has a commit and a tag still sitting around even though publishing failed.

It'd be much better if the tag/commit were added after a successful publish or was somehow unwindable rather than me having to peck around for git reset + git tag --delete.

pksunkara commented 3 months ago

Duplicate of #13.

I would appreciate it if you could list the needed things here. I haven't encountered this issue and thus will not be perfect in implementing this. What should I revert in version failure and publish failure?