search

pksunkara / octonode

github api v3 in nodejs
MIT License
1.19k stars 237 forks source link

Adds support for PR Reviews #277

Closed MattCopenhaver closed 7 years ago

MattCopenhaver commented 7 years ago

Support for these these methods: https://developer.github.com/v3/pulls/reviews/

MattCopenhaver commented 7 years ago

I was not sure if I should be checking in the compiled code in lib directory. I decided to since it is already in the repo.

After that I found #19 and #21. I am wondering what your perspective is on that. Checking lib in certainly solves that issue, but feels a bit odd. Could we solve the same issue by adding a postinstall script, which would compile the code, to package.json? This way if you npm install from Github, it would still work, but the published version in NPM would remain the same.

pksunkara commented 7 years ago

I am not sure if that would solve the issue. And I don't plan on checking it anytime soon. Will leave it upto you if you want to check.

MattCopenhaver commented 7 years ago

@pksunkara The postinstall may not be as straightforward as I thought. I've used it in internal dependencies that were never published to npm and only pulled straight from Github repos. You would definitely not want to run postinstall from an npm dependency. So while it would probably solve the issue, it would create another larger issue.