search

pksunkara / octonode

github api v3 in nodejs
MIT License
1.19k stars 237 forks source link

Updated Readme to include Async functions #320

Closed Circuit8 closed 6 years ago

Circuit8 commented 6 years ago

https://github.com/pksunkara/octonode/issues/314

pksunkara commented 6 years ago

Why did you add the second commit? I like the first one.

Circuit8 commented 6 years ago

Hey sorry just read this, I think it contained an error

tomsiwik commented 5 years ago

I'm confused. I can't find any <methodName>Async(...) methods stated in the README.md. However, I see:

https://github.com/pksunkara/octonode/commit/5cbb4a437a9c67a84df5080efab43fc1f27f80a4

Now, how do I return a promise/async for the chained methods? repo is a promise, repo(...).contents(...) is not.

pksunkara commented 5 years ago

repo(...).contentsAsync(...)