search

pksunkara / pgx_ulid

Postgres extension for ulid
MIT License
324 stars 21 forks source link

Commit Cargo.lock #33

Closed tomhoule closed 9 months ago

tomhoule commented 9 months ago

There are valid reasons to disagree, but since this crate is more an artifact that is built and distributed than a library crate consumed as such, it would make sense to commit the Cargo.lock for reproducible builds. As a point of comparison, timescaledb-toolkit is also a pgrx project, they commit their lock file. This question is coming from noticing how others do it, and because it's slightly inconvenient for nix packaging — definitely not a blocker though.

What do you think?

pksunkara commented 9 months ago

It must have been an oversight but yes, I agree with your logic.