search

pksunkara / pgx_ulid

Postgres extension for ulid
MIT License
346 stars 21 forks source link

Relax pgrx requirements #41

Closed gjtorikian closed 6 months ago

gjtorikian commented 6 months ago

As discussed in https://github.com/pksunkara/pgx_ulid/pull/34#issuecomment-2119023072

pksunkara commented 6 months ago

Can you please test this locally? Something seems to be failing.

gjtorikian commented 6 months ago

I had tested it locally, but not run the test suite. It seems pgrx-tests has a dependency on clap-cargo which recently updated its MSRV: 

error: package `clap_derive v4.5.4` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.70.0
Either upgrade to rustc 1.74 or newer, or use
cargo update -p clap_derive@4.5.4 --precise ver
where `ver` is the latest version of `clap_derive` supporting rustc 1.70.0

CI hasn’t been run on this repo since that change, so it had not been seen before.

pksunkara commented 6 months ago

Please rebase on master.

gjtorikian commented 6 months ago

done