search

pktgen / Pktgen-DPDK

DPDK based packet generator
Other
392 stars 120 forks source link

dpdk-version.sh does not work with new version of DPDK #273

Closed Binary-Vanguard-12138 closed 3 months ago

Binary-Vanguard-12138 commented 4 months ago

dpdk-version.sh tries to open and parse dpdk/lib/librte_eal/common/include/rte_version.h. But this file moved to dpdk/lib/eal/include/rte_version.h in the new version of DPDK.

KeithWiles commented 4 months ago

Looks like we need to update the script to try both locations to support older DPDK version :-(

KeithWiles commented 3 months ago

Looking at the script it has a number of issues as the information in is now contained in two files rte_config.h and rte_build_config.h. This script is not used anymore inside Pktgen and it appears it was created back in 2017.

Pktgen only builds against the installed version of DPDK anyway, so I am going to remove the script unless you have an objection.

Binary-Vanguard-12138 commented 3 months ago

Looking at the script it has a number of issues as the information in is now contained in two files rte_config.h and rte_build_config.h. This script is not used anymore inside Pktgen and it appears it was created back in 2017.

Pktgen only builds against the installed version of DPDK anyway, so I am going to remove the script unless you have an objection.

Yeah, that should be fine. I have no objection.

KeithWiles commented 3 months ago

Ok, thanks. I will remove it in an upcoming update. I will close this issue.