workspacemechanic does not show a problem when pointing to wrong directory

pkuashi / workspacemechanic

Automatically exported from code.google.com/p/workspacemechanic

0 stars 0 forks source link

workspacemechanic does not show a problem when pointing to wrong directory #98

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1. set workspacemechanic to some directory that does NOT contain 
workspacemechanic files

What is the expected output? What do you see instead?
I'd expect the workspacemechanic icon to be yellow and indicate that the 
configuration probably points to the wrong directory.
Instead it is green and looks like everything is fine.

--> We have problems deploying eclipse changes via workspacemechanic since 
users report that they have the latest changes (since the icon is green) when 
they in fact don't have them

What version of the product are you using? On what operating system?
Win7, Java1.7, Eclipse Juno, workspacemechanic 0.1.5

Original issue reported on code.google.com by sebidiet...@gmail.com on 12 Sep 2012 at 12:32

GoogleCodeExporter commented 8 years ago

This is somewhat of a chicken and egg problem. Missing mechanic files is an 
unknown unknown, and one can't reasonably code for that.

I'll be happy to accept a patch request, with tests, if the algorithm is right.

Original comment by konigsb...@gmail.com on 13 Sep 2012 at 8:10

Added labels: Type-Enhancement
Removed labels: Type-Defect

GoogleCodeExporter commented 8 years ago

Sorry I don't understand. Why can't we just check if a directory is empty?

Original comment by sebidiet...@gmail.com on 13 Sep 2012 at 3:35

GoogleCodeExporter commented 8 years ago

Seems reasonable to me. If I have multiple directories listed, and only one of 
them is empty, show the same warning? What if I want to ignore that warning? 
What if I have tasks that are not file-based - probably doesn't impact anything.

Anyway, as I mentioned earlier, a patch is ideal.

Original comment by konigsb...@gmail.com on 13 Sep 2012 at 6:17

GoogleCodeExporter commented 8 years ago

No problem. Please check if the following functionality would be ok for you:

Workspacemechanic icon changes to warning (like ok sign, but in orange) 
whenever one of the directories listed is empty.
The workspacemechanic popup then lists the empty directories. You can select 
"ignore" for each of them. When all empty directories are ignored, the icon 
changes again to ok sign.

Only impacts file-based tasks.

Original comment by sebidiet...@gmail.com on 17 Sep 2012 at 10:18

GoogleCodeExporter commented 8 years ago

Task repair implies task failure, and you're defining an entirely new state. I 
wouldn't bother with the task repair.

Original comment by konigsb...@gmail.com on 17 Sep 2012 at 11:26