search

pkuehnel / TeslaSolarCharger

A software to let your Tesla charge with solar energy ☀
GNU General Public License v3.0
129 stars 21 forks source link

feat/weekdaycharging #1340

Closed pkuehnel closed 1 month ago

pkuehnel commented 3 months ago

@b1ggi Unit tests seem to fail. If you resolve that, I will create a release to test the feature.

b1ggi commented 3 months ago

Fix for failed tests in PR https://github.com/pkuehnel/TeslaSolarCharger/pull/1342

pkuehnel commented 3 months ago

@b1ggi You can now test everything using :weekdaycharging as tag instead of :latest.

b1ggi commented 3 months ago

Found a bug image The new Box only appears after pressing CTRL+F5 image

will fix on weekend

pkuehnel commented 3 months ago

@b1ggi I think that is not a weekdaycharging specific bug, but thanks in advance for resolving it.

pkuehnel commented 2 months ago

@b1ggi due to various overlapping changes I needed to rebase the branch onto develop. Please use the latest version for your fixes.

pkuehnel commented 2 months ago

@b1ggi Just noticed that due to my rebase all commits are counted for me so you need to make another commit to be mentioned as a contributor -.-

pkuehnel commented 2 months ago

@b1ggi needed to reabase again, sorry. I just released again without that feature, can you tell me when you are ready and everything is tested?

b1ggi commented 1 month ago

@pkuehnel i tested the feature now for 1 month (i recently also installed a 32kwh diy-battery) and it works like expected, and im very happy with the feature, it really helps to optimize charging for a normal Mo-Fr week.

It would be nice if it would be possible to select specific Days to charge, but if there is no demand, i think were good.

I cannot reproduce the bug i mentioned above, i think it was a browser cache problem after updating.

pkuehnel commented 1 month ago

Thanks for your effort. As I needed to fix a few merge conflicts you won't be displayed as contributor. If you want to be displayed (And to be honest I want the list of contributors to be complete), create a fork from this branch and remove the first line of this file.

b1ggi commented 1 month ago

https://github.com/pkuehnel/TeslaSolarCharger/pull/1417

Like this?

pkuehnel commented 1 month ago

@b1ggi You can now update to :edge. This is the latest alpha release, including your weekday charging feature. When the next version is released, your feature will be included. Thanks a lot.