IDE doesn't obey my gtk theme

pkulchenko / ZeroBraneStudio

Lightweight Lua-based IDE for Lua with code completion, syntax highlighting, live coding, remote debugger, and code analyzer; supports Lua 5.1, 5.2, 5.3, 5.4, LuaJIT and other Lua interpreters on Windows, macOS, and Linux

http://studio.zerobrane.com/

Other

2.6k stars 519 forks source link

IDE doesn't obey my gtk theme #1089

Closed Shadowblitz16 closed 3 years ago

Shadowblitz16 commented 3 years ago

ZeroBrane studio doesn't obey my gtk theme

ildar commented 3 years ago

Check your GTK3 theme. Also environment info could be helpful : distro, DE?

Shadowblitz16 commented 3 years ago

I am on zorin os core 15.3 And the distro uses its own themes

pkulchenko commented 3 years ago

There is not much I can do, as those colors that GUI is using are coming from whatever reported by GTK3 and there is no way to modify them (all) unfortunately. I've open a ticket some time ago that allows better configuration, but the changes haven't been implemented yet (https://trac.wxwidgets.org/ticket/18614).

Shadowblitz16 commented 3 years ago

@pkulchenko can we reopen this on a later date?

pkulchenko commented 3 years ago

I'm not sure if there is a bug with the colors that wxwidgets is getting, but we can definitely revisit this when the ticket I referenced is implemented and the binaries in the IDE are refreshed to include that logic.

You can still configure the colors in the IDE, just not all of the elements (like menus, borders, tabs, and few other things).

Shadowblitz16 commented 3 years ago

I thought wxwidgets used gtk on linux cocoa on mac and win32 in windows? I don't see how its not using my gtk theme

pkulchenko commented 3 years ago

Yes, that's correct.

It's not clear from the screenshot what happens. Can you run the following commands in the Console and report the results back:

wx.wxSystemSettings.GetColour(wx.wxSYS_COLOUR_3DFACE):GetAsString()
wx.wxSystemSettings.GetColour(wx.wxSYS_COLOUR_CAPTIONTEXT):GetAsString()
wx.wxSystemSettings.GetColour(wx.wxSYS_COLOUR_INACTIVECAPTIONTEXT):GetAsString()

You can also check the discussion in #1024, which dealt with a similar issue. Could you include a screenshot that shows not just the IDE, but also some other application that uses the correct theme colors?

Shadowblitz16 commented 3 years ago

I ran the commands and they print in order..

"white"
"black"
"black"

also i will check it out

pkulchenko commented 3 years ago

So it looks like the colors are correct and somewhat correspond to the colors in other apps (judging by the screenshots). You may argue that the style is different, but picking colors between different managers is a crude method, so I guess this is the best that wxwidgets can do.

If you are talking about tab bar gradient that is present in the IDE, but is not present in the other apps, it can be adjusted (and I've been considering making it configurable). You may try setting wxaui.wxAuiGenericTabArt = nil in the config, which will reset the tabbar style.

Shadowblitz16 commented 2 years ago

@pkulchenko maybe it's time to switch to a flat theme like vs code? I'm on kde neon now and it still looks awful. What ui are you using?