search

pkulchenko / wxlua

wxlua: Lua bindings for wxWidgets cross-platform GUI toolkit; supports Lua 5.1, 5.2, 5.3, 5.4, LuaJIT and wxWidgets 3.x
304 stars 59 forks source link

Fix issues when building against wxWidgets 3.2.0-rc1 #109

Closed solemnwarning closed 2 years ago

pkulchenko commented 2 years ago

@solemnwarning, thank you for the patch! I was just working on this few days ago. Can you try compiling using the version in https://github.com/pkulchenko/wxlua/tree/fix-wxbitmap? I plan to merge it shortly, but it's likely to cause the conflicts with this path. If the branch works for you on wxwidgets 3.2, then I may integrate some of your changes, as you added version changes (which I ignored in my patch, as the changes appear to work on older versions of wxwidgets too).

solemnwarning commented 2 years ago

@pkulchenko the fix-wxbitmap branch works for me. The version checks aren't really necessary, but will avoid some redundant allocations/copies on older wxWidgets.