search

pkulchenko / wxlua

wxlua: Lua bindings for wxWidgets cross-platform GUI toolkit; supports Lua 5.1, 5.2, 5.3, 5.4, LuaJIT and wxWidgets 3.x
304 stars 59 forks source link

wxRichTextCtrl and related classes are implemented #111

Closed toshinagata closed 1 year ago

toshinagata commented 2 years ago

This is a very large patch. It still contains severals TODO's left, but basically it is working (at least on my side). I also added an example script (taken from "RichTextCtrl overview" with a little modification)

pkulchenko commented 2 years ago

@toshinagata, thank you for the patch! Do you expect me to wait until TODOs are implemented or would you prefer to merge it as is? I'd like to do a release soon, so prefer would not leave it in some incomplete state...

toshinagata commented 2 years ago

@pkulchenko, thank you for your comment! In fact, I am already aware of some issues for this patch besides the TODOs, so it would be better not to merge this patch as it is. You can close this PR without merging, and let me request again when the patch looks better and complete.

pkulchenko commented 2 years ago

I think it's fine to keep it open and you can always force push this branch if you need to make any changes to the history.

I'll wait for your update before merging.

toshinagata commented 2 years ago

Sure, I will be back again when a new patch is ready.

toshinagata commented 2 years ago

I have completed my TODO list, and have taken care of the issues found so far. I believe this patch is ready to go now.

pkulchenko commented 1 year ago

@toshinagata, looks good to me; thank you for the patch! I made a couple of small changes to the sample to make it run.