search

pkulchenko / wxlua

wxlua: Lua bindings for wxWidgets cross-platform GUI toolkit; supports Lua 5.1, 5.2, 5.3, 5.4, LuaJIT and wxWidgets 3.x
306 stars 59 forks source link

Move defines to h #122

Closed zdx789 closed 1 year ago

zdx789 commented 1 year ago

solved compile failed with larger 3.0.0 and lua 5.1

pkulchenko commented 1 year ago

@zdx789, thank you for the patch. What issue are you trying to resolve? I'm regularly compiling with wxwidgets 3.x and Lua 5.1 and haven't seen any compilation issues. I don't mind merging, but want to make sure the rationale is properly captured in the ticket.

zdx789 commented 1 year ago

@pkulchenko, possible issue with multithreaded compilation. please use visual studio 2019 to complie.