alex-eg commented 7 years ago

Well, actually it's just renaming EnemyWave to Level, since EnemyWave turned out to be just that type of sequence handler that makes it fit for xoinvader level support.

Also this commit moves all game objects in TestLevel class in InGame state, as they all are part of the level, not the state. This division came quite natural, which is good. Now we can proceed to move test level to separate module and to create something more elaborate, with more enemies and backgrounds, and expiriment with level utils, like enemy ships cleanup and so on.

Tests and imports were altered according to name changes. No logic changes in the engine were implemented.

issue #22

Closes issue(s): [ #22 ]

Description of the changes:

What's new: Level-related objects moved to TestLevel class in InGame state.
Refactoring: EnemyWave renamed to Level, as it actually was it from the beginning.

Reviewers: [ @pkulev ]

Task list:

[x] submit pull request
[ ] review
[ ] testing
[ ] fixes after review, squashing, rebasing to master

codecov-io commented 7 years ago

Codecov Report

Merging #56 into master will increase coverage by 0.02%. The diff coverage is 10%.

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   62.36%   62.39%   +0.02%     
==========================================
  Files          40       40              
  Lines        2086     2085       -1     
==========================================
  Hits         1301     1301              
+ Misses        785      784       -1

Impacted Files	Coverage Δ
xoinvader/ingame.py	`0% <0%> (ø)`	:white_check_mark:
xoinvader/tests/test_level.py	`100% <100%> (ø)`
xoinvader/level.py	`96.77% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 45c543d...c87f99c. Read the comment docs.

pkulev commented 7 years ago

@taptap, maybe it's better to separate EventSequensor from Level? Maybe we can use this sequensor somewhere in the engine later.

pkulev / xoinvader

implement Level support for xoinvader game #56

Codecov Report