search

pkuvcl / xavs2

An open-source encoder of AVS2-P2/IEEE1857.4 video coding standard
GNU General Public License v2.0
234 stars 66 forks source link

reserved identifier violation #1

Closed elfring closed 6 years ago

elfring commented 6 years ago

I would like to point out that identifiers like “__XAVS2ENC_H__” and “_U_” do not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

luofalei commented 6 years ago

Does it mean that we should revise the identifiers like __XAVS2ENC_H__ to XAVS2ENC_H by removing leading and trailing underscores? Thank you.

luofalei commented 6 years ago

@elfring Thanks for your suggestion, the identifiers has been fixed.

elfring commented 6 years ago

Thanks for your source code improvement.

Another update candidate was left over.