search

pkuvcl / xavs2

An open-source encoder of AVS2-P2/IEEE1857.4 video coding standard
GNU General Public License v2.0
234 stars 66 forks source link

Build fails with gcc8 #17

Closed dbermond closed 5 years ago

dbermond commented 5 years ago

Describe the bug

I'm getting the following error when trying to build xavs2 git master with gcc8:

To Reproduce

The steps to reproduce are already described on the above link.

Expected behavior

A successful build with gcc8.

Screenshots

Not applicable.

Desktop (please complete the following information):

Additional context

It builds fine when using gcc 7.3.1.

luofalei commented 5 years ago

Thanks for pointing out the bugs. Could you help to figure out which intrinsic brings in the bug or fix this problem?

dbermond commented 5 years ago

@luofalei It looks like that _mm256_insertf128_si256 and _mm256_castsi128_si256 are undeclared in the scope of source/common/vec/intrinsic.h, which seems to be strictly not permitted by gcc8.

I have created a pull request that fixes this issue.

After applying the fix, xavs2 builds fine for me with the following gcc versions:

:heavy_check_mark: gcc 8.2.1 :heavy_check_mark: gcc 7.3.1 :heavy_check_mark: gcc 6.5.0