search

pkuvcl / xavs2

An open-source encoder of AVS2-P2/IEEE1857.4 video coding standard
GNU General Public License v2.0
235 stars 66 forks source link

soname computed wrong #19

Closed jonassmedegaard closed 5 years ago

jonassmedegaard commented 5 years ago

When building xavs2 on Linux as a shared library, the computed soname seems wrong.

Current soname is 13, and seems computed by simply merging MAJOR and MINOR as strings.

That may work now, but will break if MINOR ever becomes a number higher than 9 (and counting starts from 0 at next major release).

There are several ways to express sonames. As it seems you want to reduce the amount of numbers needing manual tracking in the code, I suggest that you adopt https://semver.org/ as versioning scheme, and then use MAJOR as soname.

jonassmedegaard commented 5 years ago

ah, I see now in historical revisions of source/xavs2.h that the current soname is explicitly maintained, and that limiting MINOR to a single-digit number is intentional.

Sorry for the noise - there is nothing wrong, then :-)