pl4nty / anutimetable

Timetable builder for the Australian National University
https://timetable.cssa.club
Creative Commons Attribution Share Alike 4.0 International
22 stars 9 forks source link

Assuming each course code has only one class per session #513

Open pl4nty opened 1 month ago

pl4nty commented 1 month ago

Category: Issue Contact:

Originally submitted via the Microsoft Form

jthvai commented 1 month ago

Possibly duplicate of #200, but allegedly that issue was resolved?

jthvai commented 1 month ago

This might be an issue in the scraper's logic - it might lack the ability to click on multiple classes. It's definitely too late for me to be seriously working on this though so I'll look again tomorrow.

Screenshot of timetabling.anu options ![Screenshot from timetabling.anu, of options selected](https://github.com/user-attachments/assets/4a9fe899-03d6-42f9-ab41-8c1deb639d26)
Screenshot of timetabling.anu output ![Screenshot from timetabling.anu, displaying both classes for MKTG7260 as expected](https://github.com/user-attachments/assets/bc5283f2-a624-418a-ac29-49f396c7e0a2)

I also wonder whether it might be a issue in the data storage format - the timetable data certainly doesn't have the ability to distinguish between class codes. Though, this might not be the cause of the data loss if it instead combines all events from the same course code (but this is an ugly solution). I haven't managed to find another course with multiple class codes and an entry in timetabling.anu yet. See next comment.

https://github.com/pl4nty/anutimetable/blob/ed81ab058f2ceb036d3bd5a46fc0d9e29bff287f/public/timetable_data/2024/S2.json#L59248-L59288

Edit: wow I can't believe GH is straight up refusing to display this snippet

jthvai commented 1 month ago

Reproduced with MNGL1003, MNGL2003, TETM1003, TETM2005

MNGL1003 ![image](https://github.com/user-attachments/assets/a5986f6b-dbe4-4b2d-aa27-6212115d15ee)
MNGL2003 ![image](https://github.com/user-attachments/assets/7fb5c51f-cc67-42e5-8925-ca6ce1e8769a)
TETM1003 ![image](https://github.com/user-attachments/assets/3e004974-1fd2-495b-b441-b1e2b84186e9)
TETM2005 ![image](https://github.com/user-attachments/assets/3a158a71-57ef-409a-b274-f6ae15709502)