search

plaans / aries

Toolbox for automated planning and combinatorial solving.
MIT License
43 stars 7 forks source link

Numeric planning #105

Closed Shi-Raida closed 11 months ago

Shi-Raida commented 11 months ago

Refactoring and fixing some bugs on resource constraints encoding.

arbimo commented 11 months ago

LGTM. Could you merge the latest master in this branch? Changes in master related to testing should take precedence over the ones in this PR.

Shi-Raida commented 11 months ago

Four problems crash on Anytime but I don't have logs from Aries so it doesn't start

arbimo commented 11 months ago

Four problems crash on Anytime but I don't have logs from Aries so it doesn't start

Most likely unrelated to this PR, I suspect that the code for checking the correctness of anytime planners does not support scheduling problems.

Shi-Raida commented 11 months ago

Four problems crash on Anytime but I don't have logs from Aries so it doesn't start

Most likely unrelated to this PR, I suspect that the code for checking the correctness of anytime planners does not support scheduling problems.

Yes, I find in planning/unified/plugin/up_aries/solver.py line 340:

assert isinstance(problem, up.model.Problem)

The four problems are SchedulingProblem which does not inherit from Problem. I'll open a new branch to fix it.