search

plaans / aries

Toolbox for automated planning and combinatorial solving.
MIT License
43 stars 6 forks source link

Unified Planning Integration #34

Closed franklinselva closed 2 years ago

franklinselva commented 2 years ago

@arbimo I am experiencing some problems with the recent deployment of unified_planning under pypi. It is strange that the recent additions seem to have some issues where I cannot access unified_planning.grpc while the unit tests still pass.

The traceback is,

Traceback (most recent call last):
  File "../aries/ext/up/problem_builder.py", line 4, in <module>
    from unified_planning.grpc.proto_writer import ProtobufWriter
  File "/Users/franklinselva/Documents/Work/plaan/unified-planning/unified_planning/grpc/proto_writer.py", line 179, in <module>
    class ProtobufWriter(Converter):
  File "/Users/franklinselva/Documents/Work/plaan/unified-planning/unified_planning/grpc/proto_writer.py", line 476, in ProtobufWriter
    @handles(unified_planning.solvers.PlanGenerationResult)
AttributeError: module 'unified_planning' has no attribute 'solvers'
arbimo commented 2 years ago

@franklinselva I fixed your issue of the planner not being run. It was due to you non awaiting on the planner's result. Due to this the main function ended and the program exited. I also added a catch to ensure that the program exits with error code 1 if panic occurs in a tokio thread.

The rest is just improvements to CI, hopefully to speed it up a bit.

franklinselva commented 2 years ago

@arbimo Thank you.

Current status: I have updated the up server and it parses the problem and tries to solve it. There is no valid plan yet since there seems to be a bug in read_values or read_state_variables functions.