search

plaans / aries

Toolbox for automated planning and combinatorial solving.
MIT License
43 stars 6 forks source link

Update Protobuf Builder and UP definition #39

Closed franklinselva closed 2 years ago

franklinselva commented 2 years ago

@arbimo I have updated the aries_grpc_api to the new definitions and added some tests to check if protobuf definitions are updated on the unified planning side.

arbimo commented 2 years ago

@franklinselva I am a bit worried of just retrieving the protobuf from the latest commit on master as it might change under our feet and cause CI failures to unrelated changes.

I think the best approach would be to add the unified-planning repository as a git submodule in the ext directory. This would allow to reference a particular commit/branch in the upstream repository. This submodule can then be checked to ensure that we have the same protobuf version. It can also be used to run integration tests or generate problems (thus not requiring the user to have the UP installed on his machine).

franklinselva commented 2 years ago

Noted. I will make the changes accordingly.