Compile UP protobuf definitions as feature

plaans / aries

Toolbox for automated planning and combinatorial solving.

MIT License

43 stars 7 forks source link

Compile UP protobuf definitions as feature #54

Closed franklinselva closed 1 year ago

franklinselva commented 1 year ago

The UP protobuf definitions can now be compiled at request as a feature through the following:

cargo build --features=unified_planning

arbimo commented 1 year ago

That's an excellent idea!

To complete it, you should:

make the tonic-build dependency only active when the feature is enabled.
document this in a grpc/api/README.md file

franklinselva commented 1 year ago

@arbimo I have updated the dependencies and documentation for building the definitions.

As a side note, this change allows the up-server to be cross compiled for windows platform.

franklinselva commented 1 year ago

The current bindings are slightly custom (with comments and formatting) and launching the CI might be failing at this stage. Shall we update the current bindings to the generated version?

The current differences when compiling bindings are available in the patch (bindings.txt).

arbimo commented 1 year ago

@franklinselva Then you should regenerate the unified_planning.rs file on your machine and commit it to the repo. (The CI is essentially to check that this was indeed done when updating the .proto). Some changes might be caused by an update of tonic build as well, but this is ok since the version is fixed by Cargo.lock