search

plabayo / rama

modular service framework to move and transform network packets
https://ramaproxy.org
Apache License 2.0
187 stars 21 forks source link

Feat-330/allow anonymous #349

Closed calebbourg closed 2 weeks ago

calebbourg commented 2 weeks ago

Adds allow_anonymous concept to existing auth layers. Issue: https://github.com/plabayo/rama/issues/330

calebbourg commented 2 weeks ago

@GlenDC I provided the logic in ProxyAuthService's Service implementation to acknowledge allow_anonymous but did not for AsyncRequireAuthorization. It seemed it may be better handled in a given AsyncAuthorizeRequest implementation as that is where operations on header values and things like that were happening in the examples. Wasn't 100% on that choice but curious what your vision was.

Also would it make sense for me to add an example showing how this might be used?

GlenDC commented 2 weeks ago

Thank you @calebbourg for your contribution, effort and patience on this one. I hope the feedback does not discourage you. As always I'm here for you if there are remarks, feedback, questions or anything else of such nature. Take care.

calebbourg commented 2 weeks ago

Thank you very much. Not discouraged at all. I welcome and appreciate the feedback. It's very helpful.