plabayo / rama

modular service framework to move and transform network packets
https://ramaproxy.org
Apache License 2.0
143 stars 13 forks source link

support boringssl support #55

Closed GlenDC closed 2 weeks ago

GlenDC commented 6 months ago

especially for the client side this is needed to emulate TLS using boringssl directly (for chromium profiles)

AlvinKuruvilla commented 4 months ago

Hey Glen, I want to take a stab at this one, but I'm not really sure where to begin. I noticed we do have rustls client so I figured it may be similar to that but other than that, I'm not sure how to proceed.

GlenDC commented 4 months ago

Hi @AlvinKuruvilla if it's all the same with you I would prefer it if you can pick up an unassigned issue. When I assign them to me already it means that I either want to do it myself, or that I am not yet 100% certain what I exactly want from the ticket. In this case it's about the 2nd. Let me elaborate, if you will.

So TLDR: I honestly do believe you are more then capable enough to do this ticket. I would however regret it if I "burn" you out just because of me not knowing exactly what and how I want the code regarding this ticket and as a consequence it might result in very long winded Pull Requests will a big ping-pong review cycle. That said, perhaps you have a better vision of it all, based on me putting this message out, and feel more then ever motivated to still do it. If so, I suggest you hop on discord and we try to have an interactive chat about it all.

But of course, as I hinted earlier, maybe for now, you can pick up an unassigned issue, and preferably one with the "good first issue" label.

Do let me know what you think. And we can take it from there.

AlvinKuruvilla commented 4 months ago

I agree with you and I appreciate the details you provided.