Squashed commit of the following:

place-labs / k8s-helm

Helm charts for PlaceOS on Kubernetes

0 stars 2 forks source link

Squashed commit of the following: #19

Closed viv-4 closed 2 years ago

viv-4 commented 3 years ago

staff api and postgres
openshift v4
single namespace
seperate release names for third party charts
internal registry option
placeos image version update
gcp https layer 7 lb

This is the merge for feat/staff-api, just forked for ease of squashed commit in the pull request Multiple features got wrapped up into this branch Have personally confirmed all works on GKE and Openshift v4

GKE now deploys with a layer 7 load balancer which requires the name of a cloud armor security policy, creating this policy in k8s-terraform is on the todo but it is a simple manual process in the meantime

w-le commented 3 years ago

Thanks for all the hard work @viv-4 , It looks mostly good to me but correct me if I'm wrong - it looks like the network policies now allow any pod to talk to placeos pods?

I'm not fully qualified to evaluate these changes so I've added @jahoward as a reviewer, thanks!

jahoward commented 3 years ago

@w-le That is correct All pods can talk to the placeos pods based on the calico configuration

w-le commented 3 years ago

thanks @jahoward , so @viv-4 I recommend we ensure that the updated network policies are not significantly looser than they were previously, before pulling this into master.

hey @jahoward can we use some of your billable time for a code review of all these changes in terms of best practices, security and style, with suggested code changes?

w-le commented 2 years ago

How's it going? Can I see the changes since our last chat a couple weeks ago?

w-le commented 2 years ago

We need to close this one soon @viv-4 it's been very long