Closed bschmalhofer closed 2 years ago
The API was changed in 6a7a5693bd1f7afd2a3d0f6b97353bc1a6abf6e7 but the argument list was not updated. The $builder
parameter can be removed.
This is fixed in 2a29db30533234b3f03022fa1191c3543090de7f. Thanks!
Hi,
I'm enhancing a web application that should run in a cluster without a shared file system. My idea was to write a custom loader module that syncs with a S3 storage and restarts the web server. A bit like
Plack::Loader::Restarter
. Looking at the code I got confused over the argument list of the loader run method.In Plack::Runner the call is:
In the custom loader modules Plack::Loader::* there argument list has two entries,
But in in the base module Plack::Loader there is is an extra unused argument:
Is this a simple oversight or did I miss something? In the former case I could provide a pull request,