search

pladaria / reconnecting-websocket

Reconnecting WebSocket. For Web, React Native, cli (Node.js)
MIT License
1.23k stars 199 forks source link

fix typings #26

Closed chaabaj closed 7 years ago

chaabaj commented 7 years ago

Fixing some typings to return a instance of ReconnectingWebSocket instead of void

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 71d9f601318cac795879aaf8fea12f47fb650771 on chaabaj:fix-typings into e79fba552f236463adac04e1872f5e20e37d66a1 on pladaria:master.

pladaria commented 7 years ago

Thank you!

pladaria commented 7 years ago

published v3.2.1

chaabaj commented 7 years ago

Since it seems that the library use more class style maybe we can move the implementation to use class instead of function.

Otherwise we can have the implementation using more functional style without using this and return an object that contain all the necessary methods.

I will try some experiment with that and make a feedback about this.