Failing test: level0 event listeners are reassigned after reconnect

pladaria / reconnecting-websocket

Reconnecting WebSocket. For Web, React Native, cli (Node.js)

MIT License

1.22k stars 197 forks source link

Failing test: level0 event listeners are reassigned after reconnect #29

Closed bennycode closed 6 years ago

bennycode commented 7 years ago

I forked "reconnecting-websocket", did npm install and ran npm test. Unfortunately, the tests are failing on my machine (Windows 10, Node.js v8.4.0):

Failing test: level0 event listeners are reassigned after reconnect Reason: Planned for 26 assertions, but got 27.

Screenshot:

Screenshot

pladaria commented 7 years ago

Works for me (linux box). Tests make use of html5-websocket which makes use of ws. Perhaps there are some subtleties from one OS to another.

pladaria commented 6 years ago

I've upgraded some dependencies. Would you mind to try again? I've tested in Linux and Mac and works fine. Please re-open if this is still an issue for Windows and I will download a VM and investigate.

Thanks