Buffering of messages while offline can now be toggled on/off via options...

pladaria / reconnecting-websocket

Reconnecting WebSocket. For Web, React Native, cli (Node.js)

MIT License

1.22k stars 197 forks source link

Buffering of messages while offline can now be toggled on/off via options... #93

Open beyond-code-github opened 5 years ago

beyond-code-github commented 5 years ago

...for example when a service is already using a persistent queue

beyond-code-github commented 5 years ago

FYI on checkout I had three test failures, perhaps this is down to my version of node/npm but just thought I would highlight it. Thanks for this project!

coveralls commented 5 years ago

Coverage increased (+0.09%) to 94.415% when pulling 162ae556c60b6fdc64036946bd46f84694f38657 on beyond-code-github:buffer-while-offline-option into c64d32fbeaf70199e7b82817476f4d9f3e35ef39 on pladaria:master.

phil-flyclops commented 5 years ago

As a heads up, I also added PR #97 that can support this by setting the queue size to 0, along with supporting other possible queue sizes

pladaria commented 5 years ago

hI, @beyond-code-github, does PR #97 solve your problem?

beyond-code-github commented 5 years ago

@pladaria yup I think that would work just fine, happy to close this in light of #97 :)

bj00rn commented 4 years ago

close?