Support a Max Queue Size for Buffered Messages

pladaria / reconnecting-websocket

Reconnecting WebSocket. For Web, React Native, cli (Node.js)

MIT License

1.22k stars 197 forks source link

Support a Max Queue Size for Buffered Messages #97

Closed phil-flyclops closed 5 years ago

phil-flyclops commented 5 years ago

Adds a variable maxEnqueuedMessages that handles setting a limit on the maximum number of messages to queue up when a connection is down. Defaults to Infinity, and can be used to disable queueing by setting the value to 0. Added a small test around the new feature, and fixed an oddity in an existing test.

coveralls commented 5 years ago

Coverage increased (+0.09%) to 94.415% when pulling f7d7bacd7909e49b0f0eb79237a567b058ce3d69 on Flyclops:master into c64d32fbeaf70199e7b82817476f4d9f3e35ef39 on pladaria:master.

nuragic commented 5 years ago

Hi! There's anything preventing this one to be merged? Thanks!

zhaoyao91 commented 5 years ago

Hi! There's anything preventing this one to be merged? Thanks!

pladaria commented 5 years ago

Thank you!