search

plaid / deprecated-async-problem

:twisted_rightwards_arrows: Solutions and non-solutions to JavaScript's async problem
186 stars 28 forks source link

@most/create #32

Closed joaomilho closed 7 years ago

joaomilho commented 7 years ago

The most implementation seems quite unnatural relying so much on promises. Something reading files using @most/create would likely be a better example.

I tried to run the examples to change 'em, but got the following error:

    throw new TypeError('Path must be a string. Received ' + inspect(path));
davidchambers commented 7 years ago

Which version of Node are you using, @joaomilho?

joaomilho commented 7 years ago

oh so many, but generally 7.x

joaomilho commented 7 years ago

Ha, GH swallowed most/create because of the @ character. Fixed now.

davidchambers commented 7 years ago

Could you try this?

$ cd /tmp
$ git clone git@github.com:plaid/async-problem.git
$ cd async-problem
$ npm install
$ nvm exec 7 npm test

This works for me on macOS 10.13.

joaomilho commented 7 years ago

sure

joaomilho commented 7 years ago

works

davidchambers commented 7 years ago

Great. Feel free to submit a pull request to make the implementation more idiomatic. :)