plaid / pattern

An example end-to-end Plaid integration to create items and fetch transaction data
MIT License
444 stars 223 forks source link

Checking: getItemsByUser() function signature diff .... #223

Closed pkreipke closed 2 years ago

pkreipke commented 2 years ago

Just checking....

The Client's useItems hook has a function getItemsByUser() here who's signature includes a refresh value but the implementation here doesn't.

Since I'm trying to understand the token update flow I thought I'd ask if that was an oversight or related in any way.

Thanks!

phoenixy1 commented 2 years ago

Hmm -- I'm not the author of the code, but looking at it I suspect this was just a copy/paste error with the signature. In either case, it doesn't seem directly to impact the token update flow since it looks like it doesn't call a Plaid API endpoint, just Pattern's own user database.

phoenixy1 commented 2 years ago

@lindawoo-plaid when you get a chance, can you take a look at this and fix if necessary?

lindawoo-plaid commented 2 years ago

yes, this is an oversight. I will fix it. Thank you!