This issue was introduced by https://github.com/plaid/pattern/pull/245 which I introduced by approving this PR without thinking about it. It turns out you can't just change the key used by a SQL query without changing any of callsites and have it work, as a matter of fact. Who knew???? The original PR changed 3 queries.
There is a third query, updateItemTransactionsCursor, which is kind of interesting, and maybe the reason why https://github.com/plaid/pattern/pull/245 worked. In the original code that migrated Pattern to sync, there was a legitimate bug in updateItemTransactionsCursor, in that it was called by updateTransactions using an ItemId when updateTransactions didn't have an ItemId, only a plaidItemId. (Why did we decide to have a primary key in the first place that was separate from the item ID??)
Reported in the Discord community.
This issue was introduced by https://github.com/plaid/pattern/pull/245 which I introduced by approving this PR without thinking about it. It turns out you can't just change the key used by a SQL query without changing any of callsites and have it work, as a matter of fact. Who knew???? The original PR changed 3 queries.
This was partially fixed by https://github.com/plaid/pattern/pull/274 which fixed one query.
This PR fixes the second query.
There is a third query, updateItemTransactionsCursor, which is kind of interesting, and maybe the reason why https://github.com/plaid/pattern/pull/245 worked. In the original code that migrated Pattern to sync, there was a legitimate bug in updateItemTransactionsCursor, in that it was called by updateTransactions using an ItemId when updateTransactions didn't have an ItemId, only a plaidItemId. (Why did we decide to have a primary key in the first place that was separate from the item ID??)
https://github.com/plaid/pattern/pull/243 fixed that callsite to match the plaid_item_id.
This PR also clarifies that updateItemTransactionsCursor takes a PlaidItemId, not an ItemId.
I haven't yet tested this because I am sick of looking at it, but I will before I merge, or maybe you can test it.