plaid / plaid-link-ios

Plaid Link iOS SDK
https://plaid.com/docs/link/ios
MIT License
133 stars 88 forks source link

Custom deprecated but no way provided to present from SwiftUI #34

Closed derikflanary closed 4 months ago

derikflanary commented 5 months ago

I'm seeing this warning now on the latest release. "'custom' is deprecated: Presenting Link with modalPresentationStyle .overFullScreen or .fullScreen is no longer supported. You may experience UI issues if you present Link using those modalPresentationStyles."

However this is the main way you provide to present Plaid is SwiftUI. How then should we present it. I can't get .viewController to work.

dtroupe-plaid commented 5 months ago

Hi @derikflanary thanks for flagging.

The deprecation is a warning about presenting Link using .overFullScreen or .fullScreen UIModalPresentationStyle. As long as you're not using either of those styles there is nothing to be concerned about.

Let me know if you have additional questions.

3a4oT commented 4 months ago

Hey, I have the same question. If it's okay to have custom, then it shouldn't be deprecated and should NOT produce a warning.

dtroupe-plaid commented 4 months ago

I'll remove the deprecation in the next release.

dtroupe-plaid commented 4 months ago

This deprecation was removed in 5.4.0