plaid / plaid-node

Node bindings for Plaid
https://plaid.com/docs
MIT License
528 stars 174 forks source link

`RemovedTransaction.transaction_id` is optional #620

Closed AlexLloyd0 closed 7 months ago

AlexLloyd0 commented 8 months ago

The type definition for RemovedTransaction is

/**
 * A representation of a removed transaction
 * @export
 * @interface RemovedTransaction
 */
export interface RemovedTransaction {
    /**
     * The ID of the removed transaction.
     * @type {string}
     * @memberof RemovedTransaction
     */
    transaction_id?: string;
}

However the docs do not describe transaction_id as nullable:

image

This is inconsistent - do we have to handle transaction_id === undefined?

phoenixy1 commented 8 months ago

Thanks for reporting, and sorry for the slow response! I think that's just an oversight in the OpenAPI file. transaction_id in this context should never be undefined.

phoenixy1 commented 7 months ago

This has now been fixed; the fix will be available in the next client library release