search

plaid / plaid-node

Node bindings for Plaid
https://plaid.com/docs
MIT License
519 stars 172 forks source link

Missing enum value #642

Open aditya-arcot opened 3 weeks ago

aditya-arcot commented 3 weeks ago

This enum SandboxItemFireWebhookRequestWebhookCodeEnum should include LOGIN_REPAIRED as this is a valid webhook code for the sandbox item fire webhook endpoint.

Link to documentation

The documentation is also not in sync for this endpoint. The endpoint summary section lists LOGIN_REPAIRED as a valid webhook code, but is missing AUTHORIZATION_GRANTED. The webhook_code specification in the request fields section includes AUTHORIZATION_GRANTED, but not LOGIN_REPAIRED.

phoenixy1 commented 3 weeks ago

@aditya-arcot this is a similar issue to https://github.com/plaid/plaid-java/pull/426 -- the /sandbox/item/fire_webhook endpoint supports only a limited subset of webhook codes. LOGIN_REPAIRED is one of the webhook codes it doesn't support, which is why it is not present in the enum.

aditya-arcot commented 3 weeks ago

LOGIN_REPAIRED is supported by this endpoint, as mentioned in the documentation at the link I provided

The /sandbox/item/fire_webhook endpoint is used to test that code correctly handles webhooks. This endpoint can trigger the following webhooks: ... LOGIN_REPAIRED: Fired when an Item recovers from the ITEM_LOGIN_REQUIRED without the user going through update mode in your app.

phoenixy1 commented 3 weeks ago

Oops, I missed that! Thanks for the correction. I've submitted a PR to fix this and it should be resolved in the next client library update.

aditya-arcot commented 3 weeks ago

No problem, sounds good