Simplify and DRY-up Processor Validation

plaid / plaid-ruby

Ruby bindings for Plaid

https://plaid.com/docs

MIT License

228 stars 144 forks source link

Simplify and DRY-up Processor Validation #497

Closed tilo closed 5 months ago

tilo commented 5 months ago

The current code has two problems:

the Array with the values for the valid processors was duplicated twice in the code (not dry, not a constant, not frozen)
the validation code for the value of processor was not dry-ed up

phoenixy1 commented 5 months ago

Thank you for the PR! However, this code is actually auto-generated by OpenAPIGenerator, so changes the model files don't impact the actual SDK since the model files are generated every time the generator is run. Also, because this code is all generated, it doesn't matter too much that it's not DRY, since nobody is writing it.