plaid / quickstart

Get up and running with Plaid Link and the API in minutes
https://plaid.com/docs/quickstart
MIT License
602 stars 644 forks source link

python container starts in the wrong context #373

Closed masinusa closed 2 years ago

masinusa commented 2 years ago

When I clone and run 'make up language=python', the build breaks because the dockerfile is being built in the quickstart/ context, instead of the quickstart/python context -- so there is no requirements.txt file.

phoenixy1 commented 2 years ago

@lindawoo-plaid or @ToddKerpelman would one of you mind looking into this? I can't run the Dockerized quickstart at all (some kind of dependency issue involving fsevents) so it's a bit tough for me to troubleshoot

lindawoo-plaid commented 2 years ago

Todd, Do you have time to take this on? I am a bit swamped right now...

On Mon, Aug 22, 2022 at 4:39 PM Alex @.***> wrote:

@lindawoo-plaid https://github.com/lindawoo-plaid or @ToddKerpelman https://github.com/ToddKerpelman would one of you mind looking into this? I can't run the Dockerized quickstart at all (some kind of dependency issue involving fsevents) so it's a bit tough for me to troubleshoot

— Reply to this email directly, view it on GitHub https://github.com/plaid/quickstart/issues/373#issuecomment-1223331714, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASQW5RSHBOT24TCJ6CIXCILV2QFTZANCNFSM57JHNHZQ . You are receiving this because you were mentioned.Message ID: @.***>

phoenixy1 commented 2 years ago

@masinusa thank you for the report! Are you blocked on this? We will definitely investigate as soon as we can, but our team staffing is a little low this week due to scheduled PTO and fintech_devcon, so it might not be until next week if that's OK.

mjs271 commented 2 years ago

The problem is #364. There's a comment on the commit (not the PR) questioning the reasoning. As far as I can tell it just deletes a necessary line--maybe intended as a fix on a different branch? Or different os/docker? I'm on Monterey/Docker v20.10.17, if that helps, and if I add the line back in the build succeeds. Although, fwiw, I'm brand new to Plaid.